From: | Tatsuo Ishii <ishii(at)postgresql(dot)org> |
---|---|
To: | tgl(at)sss(dot)pgh(dot)pa(dot)us |
Cc: | ishii(at)sraoss(dot)co(dot)jp, ishii(at)postgresql(dot)org, andres(at)anarazel(dot)de, pgsql-hackers(at)postgresql(dot)org, teodor(at)sigaev(dot)ru |
Subject: | Re: pg_trgm |
Date: | 2010-05-27 14:39:07 |
Message-ID: | 20100527.233907.28787479.t-ishii@sraoss.co.jp |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
> Well, that doesn't mean that the answer is to use C locale ;-)
Of course it's up to user whether to use C locale or not. I just want
pg_trgm work with C locale as well.
> However, you could possibly think about making this bit of code
> more flexible:
>
> #ifdef KEEPONLYALNUM
> #define iswordchr(c) (t_isalpha(c) || t_isdigit(c))
> #else
> #define iswordchr(c) (!t_isspace(c))
> #endif
>
> Currently it seems to be hard-wired to the first case in standard
> builds.
Yup. Here is the patch in my mind:
*** trgm_op.c~ 2009-06-11 23:48:51.000000000 +0900
--- trgm_op.c 2010-05-27 23:38:20.000000000 +0900
***************
*** 59,65 ****
}
#ifdef KEEPONLYALNUM
! #define iswordchr(c) (t_isalpha(c) || t_isdigit(c))
#else
#define iswordchr(c) (!t_isspace(c))
#endif
--- 59,65 ----
}
#ifdef KEEPONLYALNUM
! #define iswordchr(c) (t_isalpha(c) || t_isdigit(c) || (lc_ctype_is_c() && !t_isspace(c)))
#else
#define iswordchr(c) (!t_isspace(c))
#endif
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2010-05-27 14:52:57 | Re: pg_trgm |
Previous Message | Tom Lane | 2010-05-27 14:24:16 | Re: pg_trgm |