Re: beta testing - pg_upgrade bug fix - double free

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: beta testing - pg_upgrade bug fix - double free
Date: 2010-05-24 17:45:01
Message-ID: 201005241745.o4OHj1728538@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Pavel Stehule wrote:
> Hello
>
> it fixes bug
>
> pg_upgrade(13359) malloc: *** error for object 0x801600:
> non-page-aligned, non-allocated pointer being freed
> *** set a breakpoint in malloc_error_break to debug
>
>
> arget 03:31 /usr/local/src/postgresql/contrib/pg_upgrade git diff .
> diff --git a/contrib/pg_upgrade/check.c b/contrib/pg_upgrade/check.c
> index 31f12fb..f989229 100644
> --- a/contrib/pg_upgrade/check.c
> +++ b/contrib/pg_upgrade/check.c
> @@ -154,7 +154,6 @@ issue_warnings(migratorContext *ctx, char
> *sequence_script_file_name)
> ctx->new.bindir,
> ctx->new.port, sequence_script_file_name,
> ctx->logfile);
> unlink(sequence_script_file_name);
> - pg_free(sequence_script_file_name);
> check_ok(ctx);
> }

Thanks for the report. Tom has applied your fix.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Stefan Kaltenbrunner 2010-05-24 18:59:35 Re: pg_upgrade docs
Previous Message Bruce Momjian 2010-05-24 17:43:02 Re: pg_upgrade docs