Re: [PATCH] Move 'long long' check to c.h

From: Michael Meskes <meskes(at)postgresql(dot)org>
To: Stephen Frost <sfrost(at)snowman(dot)net>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: [PATCH] Move 'long long' check to c.h
Date: 2010-05-24 16:13:55
Message-ID: 20100524161355.GA15029@feivel.credativ.lan
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, May 22, 2010 at 11:20:50PM -0400, Stephen Frost wrote:
> git diff -p), I noted that c.h is already included by both extern.h
> and ecpg.header through postgres_fe.h. Given this and that we're
> already doing alot of similar #define's there (unlike in those other
> files), I felt c.h was a more appropriate place. Putting it in c.h
> also means we don't have to duplicate that code.

But do other parts of PG also need it? Keep in mind that this works for ecpg
because it needs LLONG_MIN or LONGLONG_MIN anyway. I'm not sure if there are
compilers that have long long without those defines, but I'd guess there
aren't.

Michael
--
Michael Meskes
Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
Michael at BorussiaFan dot De, Meskes at (Debian|Postgresql) dot Org
ICQ 179140304, AIM/Yahoo/Skype michaelmeskes, Jabber meskes(at)jabber(dot)org
VfL Borussia! Força Barça! Go SF 49ers! Use Debian GNU/Linux, PostgreSQL

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Meskes 2010-05-24 16:15:26 Re: [PATCH] Move 'long long' check to c.h
Previous Message Robert Haas 2010-05-24 15:43:33 Re: Exposing the Xact commit order to the user