pgsql: Ensure that top level aborts call XLogSetAsyncCommit().

From: sriggs(at)postgresql(dot)org (Simon Riggs)
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Ensure that top level aborts call XLogSetAsyncCommit().
Date: 2010-05-13 11:39:30
Message-ID: 20100513113930.926257541D2@cvs.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Log Message:
-----------
Ensure that top level aborts call XLogSetAsyncCommit(). Not doing
so simply leads to data waiting in wal_buffers which then causes
later commits to potentially do emergency writes and for all forms
of replication to be potentially delayed without need or benefit.
Issue pointed out exactly by Fujii Masao, following bug report
by Robert Haas on a separate though related topic.

Modified Files:
--------------
pgsql/src/backend/access/transam:
xact.c (r1.290 -> r1.291)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/access/transam/xact.c?r1=1.290&r2=1.291)

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Eisentraut 2010-05-13 11:49:48 pgsql: Fix vpath installation from distribution tarball (bug #5447)
Previous Message Simon Riggs 2010-05-13 11:15:38 pgsql: Cleanup initialization of Hot Standby.

Browse pgsql-hackers by date

  From Date Subject
Next Message Simon Riggs 2010-05-13 11:40:39 Re: weird hang while running in HS mode
Previous Message Simon Riggs 2010-05-13 11:18:29 Re: weird hang while running in HS mode