Oddly indented raw_expression_tree_walker

From: Takahiro Itagaki <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>
To: pgsql-hackers(at)postgresql(dot)org
Subject: Oddly indented raw_expression_tree_walker
Date: 2010-04-08 05:38:45
Message-ID: 20100408143844.95FA.52131E4D@oss.ntt.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

I found raw_expression_tree_walker() is oddly indented in 8.4 and HEAD.
I expected pgindent would fix those clutter, but it could not.
Should we cleanup it manually, or leave it as-is?
Also, should we backport such kind of cleanups to previous releases?

Index: src/backend/nodes/nodeFuncs.c
===================================================================
@@ -2198,7 +2198,7 @@
* that could appear under it, but not other statement types.
*/
bool
- raw_expression_tree_walker(Node *node, bool (*walker) (), void *context)
+raw_expression_tree_walker(Node *node, bool (*walker) (), void *context)
{
ListCell *temp;

Regards,
---
Takahiro Itagaki
NTT Open Source Software Center

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Fujii Masao 2010-04-08 06:33:51 Re: Streaming replication and a disk full in primary
Previous Message Jaime Casanova 2010-04-08 05:17:02 Re: A maze of twisty mailing lists all the same