Re: booleans in recovery.conf

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Simon Riggs <simon(at)2ndQuadrant(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgreSQL(dot)org>
Subject: Re: booleans in recovery.conf
Date: 2010-03-31 14:19:51
Message-ID: 201003311419.o2VEJp815258@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Simon Riggs wrote:
> On Tue, 2010-03-23 at 19:43 -0400, Bruce Momjian wrote:
> > Is there a reason that recovery.conf uses true/false, while
> > postgresql.conf uses on/off?
> >
> > #recovery_target_inclusive = 'true' # 'true' or 'false'
> >
> > or are these settings more boolean for some reason?
>
> The code accepts any of on|off|true|false and uses the same code as the
> postgresql.conf for parsing that.
>
> I've changed the standby_mode to on|off as per the docs. I left the
> above parameter because true|false reads better.

Agreed. I also applied the attached change so defaults are listed and
example values only appear as comments in the file. This makes the file
match postgresql.conf in style.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

Attachment Content-Type Size
/rtmp/diff text/x-diff 3.4 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Dunstan 2010-03-31 14:27:03 pgindent excluded files list
Previous Message Robert Haas 2010-03-31 13:55:35 Re: sorry, too many standbys already vs. MaxWalSenders vs. max_wal_senders