Re: lock mode for ControlFileLock which pg_start_backup uses

From: Takahiro Itagaki <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>
To: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: lock mode for ControlFileLock which pg_start_backup uses
Date: 2010-03-10 02:09:40
Message-ID: 20100310110939.90A3.52131E4D@oss.ntt.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:

> Currently pg_start_backup() accesses the shared ControlFile
> by using ControlFileLock with LW_EXCLUSIVE lock mode. But
> since that access is read-only operation, LW_SHARED should
> be chosen instead of LW_EXCLUSIVE.
>
> The attached patch changes the lock mode which pg_start_backup()
> uses. Is it worth applying this patch?

Thanks, applied.

Regards,
---
Takahiro Itagaki
NTT Open Source Software Center

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2010-03-10 02:52:39 Warning about invalid .pgpass passwords
Previous Message Tom Lane 2010-03-10 00:26:57 Re: Access violation from palloc, Visual Studio 2005, C-language function