| From: | Bruce Momjian <bruce(at)momjian(dot)us> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Dominic Bevacqua <dominic(dot)bevacqua(at)bpmlogic(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Re: incorrect exit code from psql with single transaction + violation of deferred FK constraint |
| Date: | 2010-03-08 00:30:18 |
| Message-ID: | 201003080030.o280UIY26032@momjian.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs pgsql-hackers |
Tom Lane wrote:
> Bruce Momjian <bruce(at)momjian(dot)us> writes:
> > The attached patch checks for the proper return from BEGIN/COMMIT, and
> > properly frees the libpq structures. In testing, this does return 3 as
> > you expected.
>
> Really? It looks to me like you'd get exit(1). Maybe that's the right
> thing, but MainLoop itself seems to return EXIT_USER not EXIT_FAILURE
> when it gets an error.
Sorry, you are right. I must have mis-read my tests. Updated patch
attached.
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com
PG East: http://www.enterprisedb.com/community/nav-pg-east-2010.do
| Attachment | Content-Type | Size |
|---|---|---|
| /pgpatches/psql-1 | text/x-diff | 727 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2010-03-08 00:47:42 | Re: Re: incorrect exit code from psql with single transaction + violation of deferred FK constraint |
| Previous Message | Tom Lane | 2010-03-07 23:26:38 | Re: Re: incorrect exit code from psql with single transaction + violation of deferred FK constraint |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Joshua Waihi | 2010-03-08 00:34:21 | Re: [HACKERS] SQL compatibility reminder: MySQL vs PostgreSQL |
| Previous Message | Tom Lane | 2010-03-07 23:26:38 | Re: Re: incorrect exit code from psql with single transaction + violation of deferred FK constraint |