From: | tgl(at)postgresql(dot)org (Tom Lane) |
---|---|
To: | pgsql-committers(at)postgresql(dot)org |
Subject: | pgsql: Make contrib/xml2 use core xml.c's error handler, when available |
Date: | 2010-03-03 19:10:22 |
Message-ID: | 20100303191022.E68987541D0@cvs.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Log Message:
-----------
Make contrib/xml2 use core xml.c's error handler, when available (that is,
in versions >= 8.3). The core code is more robust and efficient than what
was there before, and this also reduces risks involved in swapping different
libxml error handler settings.
Before 8.3, there is still some risk of problems if add-on modules such as
Perl invoke libxml without setting their own error handler. Given the lack
of reports I'm not sure there's a risk in practice, so I didn't take the
step of actually duplicating the core code into older contrib/xml2 branches.
Instead I just tweaked the existing code to ensure it didn't leave a dangling
pointer to short-lived memory when throwing an error.
Modified Files:
--------------
pgsql/contrib/xml2:
xpath.c (r1.28 -> r1.29)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/contrib/xml2/xpath.c?r1=1.28&r2=1.29)
xslt_proc.c (r1.19 -> r1.20)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/contrib/xml2/xslt_proc.c?r1=1.19&r2=1.20)
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2010-03-03 19:10:29 | pgsql: Make contrib/xml2 use core xml.c's error handler, when available |
Previous Message | Tom Lane | 2010-03-03 17:30:01 | pgsql: Export xml.c's libxml-error-handling support so that contrib/xml2 |