Re: strict version of version_stamp.pl

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: David Fetter <david(at)fetter(dot)org>
Cc: Andrew Dunstan <andrew(at)dunslane(dot)net>, jd(at)commandprompt(dot)com, pgsql-hackers(at)postgresql(dot)org
Subject: Re: strict version of version_stamp.pl
Date: 2010-02-25 22:39:10
Message-ID: 201002252239.o1PMdAk16032@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


David, I am sorry this didn't get applied, and the code has drifted too
much to apply it now. Would you be able to make a new patch to make our
Perl files strict?

---------------------------------------------------------------------------

David Fetter wrote:
> On Fri, May 08, 2009 at 09:04:18PM -0400, Andrew Dunstan wrote:
> >
> >
> > Joshua D. Drake wrote:
> >> Hello,
> >>
> >> Here is a diff of version_stamp.pl. It is not quite done as I can't
> >> actually get it to run. No matter what I do it doesn't appear to be able
> >> to open configure.in.
> >>
> >> If someone could help me figure out where I am being stupid I would
> >> appreciate it.
> >
> >
> > Maybe you aren't running it in the right directory (i.e. the directory
> > where configure.in exists)?
> >
> > Anyway, I think what you want to achieve (without all the git crap) is
> > the attached.
>
> Here's some git crap, but it makes all the .pl programs strict-clean.
> Many are still horrendous, though.
>
> Cheers,
> David.
> --
> David Fetter <david(at)fetter(dot)org> http://fetter.org/
> Phone: +1 415 235 3778 AIM: dfetter666 Yahoo!: dfetter
> Skype: davidfetter XMPP: david(dot)fetter(at)gmail(dot)com
>
> Remember to vote!
> Consider donating to Postgres: http://www.postgresql.org/about/donate

[ Attachment, skipping... ]

>
> --
> Sent via pgsql-hackers mailing list (pgsql-hackers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgsql-hackers

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com
PG East: http://www.enterprisedb.com/community/nav-pg-east-2010.do
+ If your life is a hard drive, Christ can be your backup. +

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2010-02-25 23:21:58 Re: trouble with to_char('L')
Previous Message Omar Bettin 2010-02-25 22:29:18 Re: feature request