Re: query cancel issues in contrib/dblink

From: Takahiro Itagaki <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Bruce Momjian <bruce(at)momjian(dot)us>, pgsql-hackers(at)postgresql(dot)org, Merlin Moncure <mmoncure(at)gmail(dot)com>
Subject: Re: query cancel issues in contrib/dblink
Date: 2010-02-25 00:41:05
Message-ID: 20100225094105.9158.52131E4D@oss.ntt.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


Robert Haas <robertmhaas(at)gmail(dot)com> wrote:

> I'm pretty sure it's the same as this:
> https://commitfest.postgresql.org/action/patch_view?id=263

Yes, (2) are resolved with the patch with a different implementation.

> (2) is fixed by RegisterXactCallback(AtEOXact_dblink). However, there
> might be any better solutions -- for example, ResourceOwner framework.

(1) still exists, but we had a consensus that we don't have to fix it
because we have async functions.

> (1) is fixed by using non-blocking APIs in libpq. I think we should
> always use non-blocking APIs even if the dblink function itself is
> a blocking-function.

Regards,
---
Takahiro Itagaki
NTT Open Source Software Center

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Simon Riggs 2010-02-25 00:41:27 Re: pg_stop_backup does not complete
Previous Message Erik Rijkers 2010-02-25 00:31:19 Re: testing cvs HEAD - HS/SR - xlog timeline 0 pg_xlogfile_name_offset