Re: [COMMITTERS] pgsql: Remove tabs in SGML.

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
Cc: Peter Eisentraut <peter_e(at)gmx(dot)net>, David Fetter <david(at)fetter(dot)org>, PG Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [COMMITTERS] pgsql: Remove tabs in SGML.
Date: 2010-02-05 19:32:13
Message-ID: 201002051932.o15JWDw04656@momjian.us
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-committers pgsql-hackers

Alvaro Herrera wrote:
> Bruce Momjian wrote:
> > Alvaro Herrera wrote:
>
> > > Maybe have the check-tabs rule as a dependency of the "check", "html"
> > > and/or "draft" rules?
> > >
> > > > + check-tabs:
> > > > + ( ! grep ' ' $(wildcard $(srcdir)/*.sgml $(srcdir)/ref/*.sgml) ) || (echo "Tabs appear in SGML files"; exit 1)
> >
> > Uh, I didn't think people wanted to actually have any tab testing in
> > their automatically. Do they?
>
> IMO that's the point of the whole exercise.

OK, done with attached patch, now done as part of 'gmake check'. If
people want it as part of the build process, please let me know.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

Attachment Content-Type Size
/rtmp/diff text/x-diff 1.0 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message James William Pye 2010-02-05 19:54:39 Re: Confusion over Python drivers
Previous Message Jeff Davis 2010-02-05 19:32:10 Re: Confusion over Python drivers

Browse pgsql-committers by date

  From Date Subject
Next Message Bruce Momjian 2010-02-05 19:34:57 pgsql: Properly document that OVER and WINDOW are Postgres reserved
Previous Message Bruce Momjian 2010-02-05 19:31:18 pgsql: Previous commit was to have tab checking as part of gmake check.