On Tuesday 02 February 2010 20:06:32 Robert Haas wrote:
> On Tue, Feb 2, 2010 at 1:34 PM, Andres Freund <andres(at)anarazel(dot)de> wrote:
> > For now it could - but it very well might be converted to sync_file_range
> > or similar, which would have different "sideeffects".
> > As the potential code duplication is rather small I would prefer to
> > describe the prime effect not the sideeffects...
> Hmm, in that case, I think the problem is that this function has no
> comment explaining its intended charter.
I agree there. Greg, do you want to update the patch with some comments or
In response to
pgsql-performance by date
|Next:||From: Rob||Date: 2010-02-02 19:11:27|
|Subject: System overload / context switching / oom, 8.3|
|Previous:||From: Pavel Stehule||Date: 2010-02-02 19:07:10|
|Subject: Re: Queries within a function|
pgsql-hackers by date
|Next:||From: Magnus Hagander||Date: 2010-02-02 19:10:26|
|Subject: Re: [COMMITTERS] pgsql: Define INADDR_NONE on Solaris when it's missing.|
|Previous:||From: Robert Haas||Date: 2010-02-02 19:06:32|
|Subject: Re: [HACKERS] Re: Faster CREATE DATABASE by delaying fsync (was 8.4.1 ubuntu karmic slow createdb)|