pgsql: Change regexp engine's ccondissect/crevdissect routines to

From: tgl(at)postgresql(dot)org (Tom Lane)
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Change regexp engine's ccondissect/crevdissect routines to
Date: 2010-02-01 02:46:01
Message-ID: 20100201024601.97BAE7541BA@cvs.postgresql.org
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-committers

Log Message:
-----------
Change regexp engine's ccondissect/crevdissect routines to perform DFA
matching before recursing instead of after. The DFA match eliminates
unworkable midpoint choices a lot faster than the recursive check, in most
cases, so doing it first can speed things up; particularly in pathological
cases such as recently exhibited by Michael Glaesemann.

In addition, apply some cosmetic changes that were applied upstream (in the
Tcl project) at the same time, in order to sync with upstream version 1.15
of regexec.c.

Upstream apparently intends to backpatch this, so I will too. The
pathological behavior could be unpleasant if encountered in the field,
which seems to justify any risk of introducing new bugs.

Tom Lane, reviewed by Donal K. Fellows of Tcl project

Tags:
----
REL8_0_STABLE

Modified Files:
--------------
pgsql/src/backend/regex:
regexec.c (r1.24 -> r1.24.4.1)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/regex/regexec.c?r1=1.24&r2=1.24.4.1)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2010-02-01 02:46:08 pgsql: Change regexp engine's ccondissect/crevdissect routines to
Previous Message Tom Lane 2010-02-01 02:45:55 pgsql: Change regexp engine's ccondissect/crevdissect routines to