pgsql: When doing a parallel restore, we must guard against out-of-range

From: tgl(at)postgresql(dot)org (Tom Lane)
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: When doing a parallel restore, we must guard against out-of-range
Date: 2010-01-19 18:39:26
Message-ID: 20100119183926.AEB377541B9@cvs.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Log Message:
-----------
When doing a parallel restore, we must guard against out-of-range dependency
dump IDs, because the array we're using is sized according to the highest
dump ID actually defined in the archive file. In a partial dump there could
be references to higher dump IDs that weren't dumped. Treat these the same
as references to in-range IDs that weren't dumped. (The whole thing is a
bit scary because the missing objects might have been part of dependency
chains, which we won't know about. Not much we can do though --- throwing
an error is probably overreaction.)

Also, reject parallel restore with pre-1.8 archive version (made by pre-8.0
pg_dump). In these old versions the dependency entries are OIDs, not dump
IDs, and we don't have enough information to interpret them.

Per bug #5288 from Jon Erdman.

Tags:
----
REL8_4_STABLE

Modified Files:
--------------
pgsql/src/bin/pg_dump:
pg_backup_archiver.c (r1.172 -> r1.172.2.1)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/bin/pg_dump/pg_backup_archiver.c?r1=1.172&r2=1.172.2.1)

Browse pgsql-committers by date

  From Date Subject
Next Message Robert Haas 2010-01-20 00:42:28 pgsql: Reformat documentation of libpq escaping functions.
Previous Message Tom Lane 2010-01-19 18:39:19 pgsql: When doing a parallel restore, we must guard against out-of-range