| From: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
|---|---|
| To: | Bruce Momjian <momjian(at)postgresql(dot)org> |
| Cc: | pgsql-committers(at)postgresql(dot)org |
| Subject: | Re: pgsql: PG_MAJORVERSION: For simplicity, use PG_MAJORVERSION rather than |
| Date: | 2010-01-06 23:58:18 |
| Message-ID: | 20100106235818.GV6129@alvh.no-ip.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Bruce Momjian wrote:
> Log Message:
> -----------
> PG_MAJORVERSION:
>
> For simplicity, use PG_MAJORVERSION rather than PG_VERSION for creation
> of the PG_VERSION file.
I think this is a bad style to use for commit messages. For GIT, a good
commit message is a first line being a summary, and a more extensive
message below. The way you used a contentless first line means that
somebody perusing a "git shortlog" or "git annotate" does not get any
useful information out of it. It would have been better phrased
like
"Use PG_MAJORVERSION define to create the PG_VERSION file
It is easier than using the PG_VERSION define."
or similar.
It is also bad for pgsql-committers list archives, because those get an
extract of the first line too.
--
Alvaro Herrera http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2010-01-07 00:09:24 | Re: pgsql: PG_MAJORVERSION: For simplicity, use PG_MAJORVERSION rather than |
| Previous Message | Bruce Momjian | 2010-01-06 23:23:51 | pgsql: PG_MAJORVERSION: For simplicity, use PG_MAJORVERSION rather than |