From: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
---|---|
To: | Hitoshi Harada <umi(dot)tanuki(at)gmail(dot)com> |
Cc: | Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk>, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: Aggregate ORDER BY patch |
Date: | 2009-12-03 19:52:33 |
Message-ID: | 20091203195233.GN5059@alvh.no-ip.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hitoshi Harada escribió:
> I found only trivial favors such like that a blank line is added
> around line 595 in the patch, and "proj" in peraggstate sounds a
> little weird to me because of surrounding "evaldesc" and "evalslot"
> ("evalproj" seems better to me). Also catversion update doesn't mean
> anything for this feature. But these are not what prevent it from
> review by a committer. So, although I'm going to look more on this
> patch, I mark this item as "Ready for Committer" for now.
AFAICS the catversion bump is needed because of the change in a parser
node.
--
Alvaro Herrera http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.
From | Date | Subject | |
---|---|---|---|
Next Message | Jonah H. Harris | 2009-12-03 19:53:46 | Re: Block-level CRC checks |
Previous Message | Tom Lane | 2009-12-03 19:25:06 | Re: [PATCH] Largeobject Access Controls (r2432) |