Re: plperl and inline functions -- first draft

From: Joshua Tolley <eggyknap(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Alexey Klyukin <alexk(at)commandprompt(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: plperl and inline functions -- first draft
Date: 2009-11-29 22:29:08
Message-ID: 20091129222908.GN3803@eddie
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, Nov 28, 2009 at 10:15:40PM -0500, Tom Lane wrote:
> Joshua Tolley <eggyknap(at)gmail(dot)com> writes:
> > Makes sense on both counts. Thanks for the help. How does the attached look?
>
> Applied with minor corrections, mainly around the state save/restore
> logic. I also put in some code to fix the memory leak noted by Tim Bunce,
> but am waiting for some confirmation that it's right before
> back-patching the pre-existing bug of the same ilk.
>
> regards, tom lane

Yay, and thanks. For the record, I'm can't claim to know whether your fix is
the Right Thing or not, so I'm witholding comment.

--
Joshua Tolley / eggyknap
End Point Corporation
http://www.endpoint.com

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Alex Hunsaker 2009-11-29 22:38:50 Re: Writeable CTE patch
Previous Message Tom Lane 2009-11-29 21:46:29 Re: Patch: Remove gcc dependency in definition of inline functions