pgsql: Remove -w (--ignore-all-space) option from pg_regress's diff

From: tgl(at)postgresql(dot)org (Tom Lane)
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Remove -w (--ignore-all-space) option from pg_regress's diff
Date: 2009-11-22 17:54:23
Message-ID: 20091122175423.E852A753FB7@cvs.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Log Message:
-----------
Remove -w (--ignore-all-space) option from pg_regress's diff calls.

We have used -w for a long time as a means of reducing the reported diff
volume when one element of a result table isn't of the expected width.
However, most of the time the results just pass anyway, so this isn't as
important as it once was. Meanwhile, the risk of missing potentially
significant deviations has gone up, particularly with psql's ability to
report error cursor positions. So, let's switch over to space-sensitive
comparisons. Per my proposal of yesterday.

(All the expected files that I can test here seem to be ready for this
already, but we'll see what the buildfarm thinks about others.)

Modified Files:
--------------
pgsql/src/test/regress:
pg_regress.c (r1.65 -> r1.66)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/pg_regress.c?r1=1.65&r2=1.66)

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2009-11-22 20:58:51 pgsql: Adjust expected-results spacing per buildfarm results.
Previous Message Heikki Linnakangas 2009-11-22 14:54:31 pgsql: Remove superfluous curly brace, fixing compilation with

Browse pgsql-hackers by date

  From Date Subject
Next Message Magnus Hagander 2009-11-22 18:59:05 Re: forget patch win32.mak.
Previous Message Jan Urbański 2009-11-22 17:35:36 Re: Partitioning option for COPY