|From:||Joshua Tolley <eggyknap(at)gmail(dot)com>|
|To:||Alexey Klyukin <alexk(at)commandprompt(dot)com>|
|Cc:||Andrew Dunstan <andrew(at)dunslane(dot)net>, pgsql-hackers(at)postgresql(dot)org|
|Subject:||Re: plperl and inline functions -- first draft|
|Views:||Raw Message | Whole Thread | Download mbox | Resend email|
On Wed, Nov 18, 2009 at 12:38:00PM +0200, Alexey Klyukin wrote:
> Yes, current_call_data can't be allocate in the SPI memory context, since it's used to extract the result after SPI_finish is called, although it doesn't lead to problems here since no result is returned. Anyway, I'd move SPI_connect after the current_call_data initialization.
> I also noticed that no error context is set in the inline handler, not sure whether it really useful except for the sake of consistency, but in case it is - here is the patch:
Makes sense on both counts. Thanks for the help. How does the attached look?
Joshua Tolley / eggyknap
End Point Corporation
|Next Message||u235sentinel||2009-11-20 00:15:05||plruby code and postgres ?|
|Previous Message||Tom Lane||2009-11-19 23:39:14||Re: Union test case broken in make check?|