Re: plperl and inline functions -- first draft

From: Joshua Tolley <eggyknap(at)gmail(dot)com>
To: Brendan Jurd <direvus(at)gmail(dot)com>
Cc: Andrew Dunstan <andrew(at)dunslane(dot)net>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: plperl and inline functions -- first draft
Date: 2009-11-16 22:19:45
Message-ID: 20091116221945.GQ22192@eddie
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On Sun, Nov 15, 2009 at 12:10:33PM +1100, Brendan Jurd wrote:
> I noticed that there was a fairly large amount of bogus/inconsistent
> whitespace in the patch, particularly in the body of
> plperl_inline_handler(). Some of the lines were indented with tabs,
> others with spaces. You should stick with tabs. There were also a
> lot of lines with a whole lot of trailing whitespace at the end.

Thanks -- I tend to forget whitespace :)

> In the documentation you refer to this feature as "inline functions".
> I think this might be mixing up the terminology ... although the code
> refers to "inline handlers" internally, the word "inline" doesn't
> appear in the user-facing documentation for the DO command. Instead
> they are referred to as "anonymous code blocks". I think it would
> improve consistency if the PL/Perl mention used the same term.

I can accept that argument. The attached patch modifies the documentation, and
fixes another inconsistency I found.

Joshua Tolley / eggyknap
End Point Corporation

Attachment Content-Type Size
plperl-inline.patch text/x-diff 8.9 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message David Fetter 2009-11-16 23:35:08 Re: next CommitFest
Previous Message Bernd Helmle 2009-11-16 22:10:08 Re: ALTER TABLE...ALTER COLUMN vs inheritance