Re: Patch for automated partitioning

From: Itagaki Takahiro <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>
To: shrish purohit <shrishpurohit(at)gmail(dot)com>
Cc: Hackers <pgsql-hackers(at)postgresql(dot)org>, kedar(dot)potdar(at)gmail(dot)com, Nikhil Sontakke <nikhil(dot)sontakke(at)enterprisedb(dot)com>
Subject: Re: Patch for automated partitioning
Date: 2009-11-02 07:44:05
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

shrish purohit <shrishpurohit(at)gmail(dot)com> wrote:

> Updated Kedar's patch sending on behalf of Kedar.
> There are not toomany modifications. It includes improvements for validating
> multi-column partitioned tables.

Thanks, but I'd like to keep the first patch as possible as simple.
I'll refer your work in the *next* step, especially partition
triggers and ALTER commands.

I glanced over your patch and find some codes that have room for improvement:

* Need to avoid RANGE and PARTITION to be reserved keywords.
* Non SQL-based operations are preferred if possible, so need to
reconsider pg_parse_query().
* Adding NOTICE message to completionTag is a very bad idea.
we don't need such feature because users can create trigger
on the overflow partition to send those messages.

ITAGAKI Takahiro
NTT Open Source Software Center

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Itagaki Takahiro 2009-11-02 07:55:59 Re: CREATE TABLE ... INHERITS (parent INCLUDING xxx)
Previous Message Simon Riggs 2009-11-02 07:38:56 Re: operator exclusion constraints