| From: | tgl(at)postgresql(dot)org (Tom Lane) |
|---|---|
| To: | pgsql-committers(at)postgresql(dot)org |
| Subject: | pgsql: Dept of second thoughts: after studying index_getnext() a bit |
| Date: | 2009-11-01 22:30:54 |
| Message-ID: | 20091101223054.C595B753FB7@cvs.postgresql.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Log Message:
-----------
Dept of second thoughts: after studying index_getnext() a bit more I realize
that it can scribble on scan->xs_ctup.t_self while following HOT chains,
so we can't rely on that to stay valid between hashgettuple() calls.
Introduce a private variable in HashScanOpaque, instead.
Modified Files:
--------------
pgsql/src/backend/access/hash:
hash.c (r1.114 -> r1.115)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/access/hash/hash.c?r1=1.114&r2=1.115)
hashsearch.c (r1.57 -> r1.58)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/access/hash/hashsearch.c?r1=1.57&r2=1.58)
pgsql/src/include/access:
hash.h (r1.94 -> r1.95)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/include/access/hash.h?r1=1.94&r2=1.95)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2009-11-01 22:31:02 | pgsql: Dept of second thoughts: after studying index_getnext() a bit |
| Previous Message | Tom Lane | 2009-11-01 21:25:33 | pgsql: Fix two serious bugs introduced into hash indexes by the 8.4 |