From: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Greg Smith <gsmith(at)gregsmith(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Parsing config files in a directory |
Date: | 2009-10-26 14:25:34 |
Message-ID: | 20091026142534.GD8812@alvh.no-ip.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Tom Lane escribió:
> Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
> > Maybe SET PERSISTENT needs to go back to postgresql.conf, add an
> > automatic comment "# overridden in persistent.conf" and put a comment
> > marker in front of the original line. That way the user is led to the
> > actual authoritative source.
>
> Doesn't that require the same AI-complete parsing ability we have said
> we don't want to implement?
Huh, no, it's not necessary to parse the comment previous to the value.
Just comment it off.
> Personally I think this is just a matter of usage. If you want to use
> SET PERSISTENT, don't set values manually in postgresql.conf. How is
> that different from the existing rule that if you want to set values in
> postgresql.conf, you'd better not set them on the postmaster command
> line?
I agree, except that some things are defined in postgresql.conf by
initdb and you probably want to be able to change them by SET PERSISTENT
anyway (e.g. lc_messages, listen_addresses, shared_buffers)
--
Alvaro Herrera http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2009-10-26 14:30:04 | Re: Endgame for all those SELECT FOR UPDATE changes: fix plan node order |
Previous Message | Tom Lane | 2009-10-26 14:19:07 | Re: Parsing config files in a directory |