pgsql: Remove very ancient tuple-counting infrastructure

From: tgl(at)postgresql(dot)org (Tom Lane)
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Remove very ancient tuple-counting infrastructure
Date: 2009-10-08 22:34:57
Message-ID: 20091008223457.D37D0753FB7@cvs.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Log Message:
-----------
Remove very ancient tuple-counting infrastructure (IncrRetrieved() and
friends). This code has all been ifdef'd out for many years, and doesn't
seem to have any prospect of becoming any more useful in the future.
EXPLAIN ANALYZE is what people use in practice, and I think if we did want
process-wide counters we'd be more likely to put in dtrace events for that
than try to resurrect this code. Get rid of it so as to have one less detail
to worry about while refactoring execMain.c.

Modified Files:
--------------
pgsql/src/backend/access/gist:
gistget.c (r1.81 -> r1.82)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/access/gist/gistget.c?r1=1.81&r2=1.82)
pgsql/src/backend/access/hash:
hashutil.c (r1.60 -> r1.61)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/access/hash/hashutil.c?r1=1.60&r2=1.61)
pgsql/src/backend/access/nbtree:
nbtutils.c (r1.93 -> r1.94)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/access/nbtree/nbtutils.c?r1=1.93&r2=1.94)
pgsql/src/backend/executor:
execMain.c (r1.330 -> r1.331)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/executor/execMain.c?r1=1.330&r2=1.331)
execQual.c (r1.251 -> r1.252)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/executor/execQual.c?r1=1.251&r2=1.252)
execUtils.c (r1.162 -> r1.163)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/executor/execUtils.c?r1=1.162&r2=1.163)
pgsql/src/backend/tcop:
postgres.c (r1.573 -> r1.574)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/tcop/postgres.c?r1=1.573&r2=1.574)
pgsql/src/include/executor:
execdebug.h (r1.34 -> r1.35)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/include/executor/execdebug.h?r1=1.34&r2=1.35)

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Eisentraut 2009-10-09 21:02:57 pgsql: Use pg_get_triggerdef in pg_dump Add a variant of
Previous Message Alvaro Herrera 2009-10-08 16:34:01 pgsql: Add the new psql command \drds to the psql docs, help and tab