pgsql: Change CREATE TABLE so that column default expressions coming

From: tgl(at)postgresql(dot)org (Tom Lane)
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Change CREATE TABLE so that column default expressions coming
Date: 2009-10-06 00:55:26
Message-ID: 20091006005526.C8C62753FB7@cvs.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Log Message:
-----------
Change CREATE TABLE so that column default expressions coming from different
inheritance parent tables are compared using equal(), instead of doing
strcmp() on the nodeToString representation. The old implementation was
always a tad cheesy, and it finally fails completely as of 8.4, now that the
node tree might contain syntax location information. equal() knows it's
supposed to ignore those fields, but strcmp() hardly can. Per recent
report from Scott Ribe.

Modified Files:
--------------
pgsql/src/backend/commands:
tablecmds.c (r1.300 -> r1.301)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/commands/tablecmds.c?r1=1.300&r2=1.301)
pgsql/src/backend/nodes:
copyfuncs.c (r1.439 -> r1.440)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/nodes/copyfuncs.c?r1=1.439&r2=1.440)
equalfuncs.c (r1.362 -> r1.363)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/nodes/equalfuncs.c?r1=1.362&r2=1.363)
outfuncs.c (r1.364 -> r1.365)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/nodes/outfuncs.c?r1=1.364&r2=1.365)
pgsql/src/backend/parser:
parse_utilcmd.c (r2.25 -> r2.26)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/parser/parse_utilcmd.c?r1=2.25&r2=2.26)
pgsql/src/include/nodes:
parsenodes.h (r1.403 -> r1.404)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/include/nodes/parsenodes.h?r1=1.403&r2=1.404)
pgsql/src/test/regress/expected:
inherit.out (r1.27 -> r1.28)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/expected/inherit.out?r1=1.27&r2=1.28)
pgsql/src/test/regress/sql:
inherit.sql (r1.12 -> r1.13)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/sql/inherit.sql?r1=1.12&r2=1.13)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2009-10-06 00:55:35 pgsql: Change CREATE TABLE so that column default expressions coming
Previous Message Alvaro Herrera 2009-10-06 00:54:26 pgsql: Really unbreak maintainer-clean.