Re: BUG #5740: contrib/spi/moddatetime.c doesn't work with timezones.

Dimitri Fontaine <dimitri(at)2ndQuadrant(dot)fr> writes:
> Dirk Heinrichs <dirk(dot)heinrichs(at)altum(dot)de> writes:
>> Please find the patch attached. It's against 8.4.5.
>>
>> extern Datum moddatetime(PG_FUNCTION_ARGS);
>> +extern Datum moddatetimetz(PG_FUNCTION_ARGS);
> [...]
>> +CREATE OR REPLACE FUNCTION moddatetimetz()
>> +RETURNS trigger
>> +AS 'MODULE_PATHNAME'
>> +LANGUAGE C;

> You can also do AS 'MODULE_PATHNAME', 'c_function_name' and maintain a
> single C function that copes with both timestamp and timestamptz
> arguments, that's what I had in mind: you still declare two functions at
> the SQL level, though.

I don't actually see any point in having two functions at all. Since
the trigger is examining the column type internally, it could perfectly
well do the right thing at runtime depending on column type.

regards, tom lane