Re: [PATCH] pgbench: new feature allowing to launch shell commands

On Tue, Sep 15, 2009 at 09:53:11PM -0400, Stephen Frost wrote:
> Michael,
>
> I just wanted to follow-up on your pgbench patch. The latest version
> that I see is from August 13th. Is that the correct patch to be
> reviewing? Do you have any other updates on it?
>
> Thanks!
>
> Stephen

Hi!

Some comments about this patch:

- You have DOS-style carriage returns, which interfere with the patch application on Unix systems.
- We'd like to see return specifically return a value (lines 1008 and 1022 in the patched version)
- We'd like to see something done with the return value from system (line 1026 in patched version)
- pg_bench functions as expected, however, your example script given on the wiki page for this patch fails (http://wiki.postgresql.org/wiki/Pgbench:_shell_command). Can we have an example that works so we can check it out? It's not really clear to us how this will be useful to others.

Thanks!

Gabrielle & Dan