It seems to miss PQclear function

From: Quan Zongliang <quanzongliang(at)gmail(dot)com>
To: pgadmin-hackers(at)postgresql(dot)org(dot)
Subject: It seems to miss PQclear function
Date: 2009-09-15 05:08:52
Message-ID: 20090915125257.924A.4125B4E5@gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

hi all

In ExecuteVoid function of pgConn class:
// Check for errors
if (lastResultStatus != PGRES_TUPLES_OK &&
lastResultStatus != PGRES_COMMAND_OK)
{
LogError(!reportError);
return false;
}

Shoud be:
// Check for errors
if (lastResultStatus != PGRES_TUPLES_OK &&
lastResultStatus != PGRES_COMMAND_OK)
{
LogError(!reportError);
PQclear(qryRes);
return false;
}

right?

-----------------------------------------------
Quan Zongliang
quanzongliang(at)gmail(dot)com

Attachment Content-Type Size
pgConn.patch application/octet-stream 316 bytes

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Guillaume Lelarge 2009-09-15 05:34:48 Re: [pgadmin-support] Possible simple enhancement
Previous Message Magnus Hagander 2009-09-15 04:54:59 Re: [pgadmin-support] Possible simple enhancement