From: | Itagaki Takahiro <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp> |
---|---|
To: | David Fetter <david(at)fetter(dot)org> |
Cc: | pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: CREATE LIKE INCLUDING COMMENTS and STORAGES |
Date: | 2009-09-08 05:56:27 |
Message-ID: | 20090908144947.8DD5.52131E4D@oss.ntt.co.jp |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
David Fetter <david(at)fetter(dot)org> wrote:
> On Mon, Sep 07, 2009 at 12:15:21PM +0900, Itagaki Takahiro wrote:
> > Here is a patch to implement the following items in our ToDo list:
> > * Add CREATE TABLE LIKE ... INCLUDING COMMENTS
> > * Have CREATE TABLE LIKE copy column storage parameters
> >
> > The syntax is:
> > CREATE TABLE clone_table (LIKE template_table INCLUDING STORAGES)
>
> This should probably read INCLUDING STORAGE (singular) instead of
> STORAGES.
Thanks. I fixed it to INCLUDING STORAGE.
In addition, I modified INCLUDING COMMENTS to copy comments not only
on columns but also on constraints. However, comments on indexes are
not copied because copied indexes are named in DefineIndex();
We don't know names of new indexes when we build a command list.
Regards,
---
ITAGAKI Takahiro
NTT Open Source Software Center
Attachment | Content-Type | Size |
---|---|---|
create-including-20090908.patch | application/octet-stream | 29.9 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Peter Eisentraut | 2009-09-08 06:25:47 | Re: LATERAL |
Previous Message | Tom Lane | 2009-09-08 04:48:18 | Re: [Pgbuildfarm-members] Snow Leopard bison/flex build problem |