| From: | Itagaki Takahiro <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp> |
|---|---|
| To: | pgsql-hackers(at)postgresql(dot)org |
| Cc: | pgsql-bugs(at)postgresql(dot)org |
| Subject: | Re: fillfactor hides autovacuum parameters in 8.4.0 |
| Date: | 2009-08-20 01:21:40 |
| Message-ID: | 20090820101205.998C.52131E4D@oss.ntt.co.jp |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs pgsql-hackers |
Here is a patch to fix a bug in handling default values in reloptions.
This fix should be applied to HEAD and 8.4.0.
I used 'magic number -1' to propagate "not-specified" information to
autovacuum process. It might look strange because the default value is
out of range of the reloption, but I think it has less impact to the
codes comapred with other solutions (dynamic default values etc.).
> To fix the bug, each field in StdRdOptions should have "not-specified" flag.
> If not specified, autovacuum should use current GUC settings instead of
> reloptions. Is it possible to change the default values of reloptions
> to some magic number (-1 or so) ?
Regards,
---
ITAGAKI Takahiro
NTT Open Source Software Center
| Attachment | Content-Type | Size |
|---|---|---|
| fix-relopts-20090820.patch | application/octet-stream | 8.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2009-08-20 03:10:09 | Re: fillfactor hides autovacuum parameters in 8.4.0 |
| Previous Message | Itagaki Takahiro | 2009-08-20 00:34:57 | Re: fillfactor hides autovacuum parameters in 8.4.0 |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2009-08-20 01:36:00 | Re: auto_explain log_verbose causes regression failure |
| Previous Message | Itagaki Takahiro | 2009-08-20 00:34:57 | Re: fillfactor hides autovacuum parameters in 8.4.0 |