From: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
---|---|
To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Greg Stark <gsstark(at)mit(dot)edu>, Bruce Momjian <bruce(at)momjian(dot)us>, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: pgindent timing (was Re: [COMMITTERS] pgsql: Refactor NUM_cache_remove calls in error report path to a PG_TRY) |
Date: | 2009-08-12 13:38:30 |
Message-ID: | 20090812133830.GD5721@alvh.no-ip.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
Robert Haas escribió:
> On Wed, Aug 12, 2009 at 12:27 AM, Tom Lane<tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> > Ah. That's a bit idiosyncratic to pgindent. What it does for a
> > function definition makes sense, I think: it lines up all the
> > parameters to start in the same column:
> That is truly bizarre. +1 from me for doing something that a
> competent C programmer can figure out without a calculator. I don't
> care what the rule is particularly, as long as it's obvious how to
> follow it. (In my own code I indent all of my continuation lines by
> one additional 4-space tab-stop. I realize this would be a horrible
> idea for PG since we don't want to change anything that's going to
> reindent the entire code base, and you might all hate it for other
> reasons anyway, but the point is that any idiot can look at it and
> figure out how it's supposed to be indented, because the rule is
> simple.)
Well, the rule here is simple too (set cinoptions=(0 if you're
Vim-enabled). It's only function prototypes that are a bit weird, and
once you understand how it works it's trivial to reproduce.
--
Alvaro Herrera http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Haas | 2009-08-12 13:56:37 | Re: pgindent timing (was Re: [COMMITTERS] pgsql: Refactor NUM_cache_remove calls in error report path to a PG_TRY) |
Previous Message | Tom Lane | 2009-08-12 13:35:30 | Re: pgindent timing (was Re: [COMMITTERS] pgsql: Refactor NUM_cache_remove calls in error report path to a PG_TRY) |
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2009-08-12 13:39:44 | Re: WIP: getting rid of the pg_database flat file |
Previous Message | Alvaro Herrera | 2009-08-12 13:35:48 | Re: WIP: getting rid of the pg_database flat file |