BUG #4965: missing tests in tools/fsync/test_fsync.c

From: "Jeff Janes" <jeff(dot)janes(at)gmail(dot)com>
To: pgsql-bugs(at)postgresql(dot)org
Subject: BUG #4965: missing tests in tools/fsync/test_fsync.c
Date: 2009-08-05 14:46:50
Message-ID: 200908051446.n75EkoJ8012542@wwwmaster.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs


The following bug has been logged online:

Bug reference: 4965
Logged by: Jeff Janes
Email address: jeff(dot)janes(at)gmail(dot)com
PostgreSQL version: 8.4.0
Operating system: Linux
Description: missing tests in tools/fsync/test_fsync.c
Details:

In the part that implements "Compare file sync methods with one 8k write",
the #ifdef OPEN_SYNC_FLAG code
is nested within the #ifdef OPEN_DATASYNC_FLAG code.

This causes o_sync to be skipped if o_dsync is unavailable, but only for
this particular section (the section with 2 8k writes doesn't have this
problem.)

Also, the statement that prints the "Compare file sync methods with one 8k
write" section title is up in the #ifdef block of a previous section, where
it might be omitted on systems without an o_sync.

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message walkerlacombe 2009-08-05 23:15:45 BUG #4966: wrong password.....
Previous Message Heikki Linnakangas 2009-08-05 14:15:25 Re: BUG #4964: return value does not agree with documentation