| From: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Itagaki Takahiro <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>, pgsql-hackers(at)postgresql(dot)org, alr(dot)nospamforme(at)gmail(dot)com, pgsql-bugs(at)postgresql(dot)org |
| Subject: | Re: BUG #4941: pg_stat_statements crash |
| Date: | 2009-07-27 03:48:58 |
| Message-ID: | 20090727034858.GI10327@alvh.no-ip.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs pgsql-hackers |
Tom Lane escribió:
> Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
> > Itagaki Takahiro escribi:
> >> Here is a patch to fix pg_stat_statements on Windows.
>
> > Hmm, it seems the comment just above the patched line needs to be fixed.
>
> I looked at that and decided it was OK as-is. How do you want to
> change it?
The reason that it doesn't need locks is not that there's no other
process running, but that it was already initialized, in the case when
found is false.
--
Alvaro Herrera http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2009-07-27 03:58:59 | Re: BUG #4941: pg_stat_statements crash |
| Previous Message | Tom Lane | 2009-07-27 03:38:18 | Re: BUG #4941: pg_stat_statements crash |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2009-07-27 03:58:59 | Re: BUG #4941: pg_stat_statements crash |
| Previous Message | Tom Lane | 2009-07-27 03:38:18 | Re: BUG #4941: pg_stat_statements crash |