Re: building without perl

From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: pgsql-hackers(at)postgresql(dot)org
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Robert Haas <robertmhaas(at)gmail(dot)com>
Subject: Re: building without perl
Date: 2009-06-24 15:44:56
Message-ID: 200906241844.56271.peter_e@gmx.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tuesday 23 June 2009 06:43:29 Tom Lane wrote:
> Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> > Tom Lane wrote:
> >> Actually, further investigation discloses that someone broke the no-Perl
> >> defense in psql's makefile back in 8.0, and we hadn't noticed till now.
> >
> > Don't we ship sql_help.h in the tarball? I thought that's all the perl
> > was used for in psql.
>
> Yeah, but the makefile protected that with "ifdef PERL", which stopped
> failing as intended when someone forced some quotes into the value of
> PERL. I'm about to commit something that hopefully will be a bit more
> robust.

So one would have only seen the difference if there was a timestamp skew in
the unpacked tarball, or indeed perl was indeed missing.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message David E. Wheeler 2009-06-24 16:05:12 Re: Extensions User Design
Previous Message Stephen Frost 2009-06-24 11:32:59 Re: [PATCH] backend: compare word-at-a-time in bcTruelen