| From: | Stephen Frost <sfrost(at)snowman(dot)net> |
|---|---|
| To: | Stefan Kaltenbrunner <stefan(at)kaltenbrunner(dot)cc> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Jeremy Kerr <jk(at)ozlabs(dot)org>, pgsql-hackers(at)postgresql(dot)org, Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Gurjeet Singh <singh(dot)gurjeet(at)gmail(dot)com> |
| Subject: | Re: [PATCH] backend: compare word-at-a-time in bcTruelen |
| Date: | 2009-06-24 11:11:11 |
| Message-ID: | 20090624111111.GE20436@tamriel.snowman.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
* Stefan Kaltenbrunner (stefan(at)kaltenbrunner(dot)cc) wrote:
> FWIW: I'm able to measure an even more significant improvement of around
> 10%:
What would be really useful would be "best case" and "worst case"
scenarios. Ideally, with profile information for this specific function
(in addition to full benchmark runs since those can show minimal
performance improvments due to other constraints, locking, etc).
Have you tried pulling this function out and running tests with all
alignment possibilities to see how it compares to the original? There's
only so many options and showing that this change always improves
performance, or at least doesn't degrade it in the worst case, would
certainly go a long way towards getting it accepted..
Thanks,
Stephen
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Stefan Kaltenbrunner | 2009-06-24 11:23:47 | Re: [PATCH] backend: compare word-at-a-time in bcTruelen |
| Previous Message | Peter Eisentraut | 2009-06-24 10:07:52 | Re: dblink for 8.4 should work without user-mappings |