Re: AlterTableCreateToastTable API still not right for pg_migrator

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgreSQL(dot)org
Subject: Re: AlterTableCreateToastTable API still not right for pg_migrator
Date: 2009-06-11 23:39:47
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Tom Lane wrote:
> I just started reading the pg_migrator source code, and I notice that
> we still didn't get AlterTableCreateToastTable's API right for
> pg_migrator's usage. It needs to be exposing an option to force
> a particular OID for the toast table. The way pg_migrator is handling
> that now is both ugly and unsafe, and it's really pretty silly when the
> underlying create_toast_table() function is perfectly capable of being
> told what we want it to do.
> There's still time to fix this before RC1. I propose adding
> "Oid toastOid" to AlterTableCreateToastTable's arguments, with
> the semantics that if it's not InvalidOid then we attempt to create
> the toast table with that OID.

I have update pg_migrator CVS to match the new API, but I will not put
out a new pg_migrator release until Postgres 8.4RC1 is released.

Bruce Momjian <bruce(at)momjian(dot)us>

+ If your life is a hard drive, Christ can be your backup. +

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Kevin Grittner 2009-06-11 23:50:46 Re: Modifying TOAST_TUPLE_THRESHOLD and TOAST_TUPLE_TARGET?
Previous Message Bruce Momjian 2009-06-11 23:22:37 Re: [COMMITTERS] pgsql: Document struct/union problem with pgindent.