Re: [COMMITTERS] pgsql: Document struct/union problem with pgindent.

From: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: Bruce Momjian <momjian(at)postgresql(dot)org>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [COMMITTERS] pgsql: Document struct/union problem with pgindent.
Date: 2009-06-11 22:54:54
Message-ID: 20090611225453.GI6401@alvh.no-ip.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Andrew Dunstan wrote:
>
>
> Bruce Momjian wrote:
>
> + #
> + # Structure/union pointers in function prototypes and definitions have an extra
> + # space after the asterisk:
> + #
> + # void x(struct xxc * a);
>
>
> I know we should not be driven by our tools, but is there a case for a
> coding standard that requires use of a typedef name here?

We use things like struct timeval and struct tm ... I don't think we
should be creating typedefs for those, so it would be good to find a
more general solution.

--
Alvaro Herrera http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2009-06-11 22:59:05 Re: [COMMITTERS] pgsql: Document struct/union problem with pgindent.
Previous Message Andrew Dunstan 2009-06-11 22:51:43 Re: [COMMITTERS] pgsql: Document struct/union problem with pgindent.

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2009-06-11 22:59:05 Re: [COMMITTERS] pgsql: Document struct/union problem with pgindent.
Previous Message Andrew Dunstan 2009-06-11 22:51:43 Re: [COMMITTERS] pgsql: Document struct/union problem with pgindent.