pgsql: Fix LIKE's special-case code for % followed by _.

From: tgl(at)postgresql(dot)org (Tom Lane)
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Fix LIKE's special-case code for % followed by _.
Date: 2009-05-24 18:10:38
Message-ID: 20090524181038.12F0775331E@cvs.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Log Message:
-----------
Fix LIKE's special-case code for % followed by _. I'm not entirely sure that
this case is worth a special code path, but a special code path that gets
the boundary condition wrong is definitely no good. Per bug #4821 from
Andrew Gierth.

In passing, clean up some minor code formatting issues (excess parentheses
and blank lines in odd places).

Back-patch to 8.3, where the bug was introduced.

Modified Files:
--------------
pgsql/src/backend/utils/adt:
like_match.c (r1.24 -> r1.25)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/adt/like_match.c?r1=1.24&r2=1.25)
pgsql/src/test/regress/expected:
strings.out (r1.37 -> r1.38)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/expected/strings.out?r1=1.37&r2=1.38)
pgsql/src/test/regress/sql:
strings.sql (r1.25 -> r1.26)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/sql/strings.sql?r1=1.25&r2=1.26)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2009-05-24 18:10:47 pgsql: Fix LIKE's special-case code for % followed by _.
Previous Message User Jbcooley 2009-05-23 02:38:39 npgsql - Npgsql2: Added DDEX solution