From: | Bruce Momjian <bruce(at)momjian(dot)us> |
---|---|
To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
Cc: | David Fetter <david(at)fetter(dot)org>, Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Keyword list sanity check |
Date: | 2009-04-30 16:40:04 |
Message-ID: | 200904301640.n3UGe9V08141@momjian.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Robert Haas wrote:
> On Thu, Apr 30, 2009 at 3:27 AM, David Fetter <david(at)fetter(dot)org> wrote:
> > On Tue, Apr 28, 2009 at 11:33:28AM +0300, Heikki Linnakangas wrote:
> >> I wrote a little perl script to perform a basic sanity check to
> >> keywords ?in gram.y and kwlist.h. It checks that all lists are in
> >> alphabetical ?order, all keywords present in gram.y are listed in
> >> kwlist.h in the ?right category, and conversely that all keywords
> >> listed in kwlist.h are ?listed in gram.y.
> >>
> >> It found one minor issue already:
> >>
> >> $ perl src/tools/check_keywords.pl 'SCHEMA' after 'SERVER' in
> >> unreserved_keyword list is misplaced
> >>
> >> SERVER is not in the right place in gram.y, it should go between
> >> SERIALIZABLE and SERVER. I'll fix that.
> >>
> >> I'll put this into src/tools. It's heavily dependent on the format
> >> of ?the lists in gram.y and kwlist.h but if it bitrots due to
> >> changes in ?those files, we can either fix it or just remove it if
> >> it's not deemed ?useful anymore.
> >
> > Please clean up this code at least to the point where it's
> > strict-clean, which means putting "use strict;" right after the
> > shebang line and not checking it in until it runs that way.
>
> And "use warnings;", too.
I now see at the top of the CVS file:
#!/usr/bin/perl -w
use strict;
so it seems it has both now.
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ If your life is a hard drive, Christ can be your backup. +
From | Date | Subject | |
---|---|---|---|
Next Message | David Fetter | 2009-04-30 16:40:50 | Re: Keyword list sanity check |
Previous Message | Andy Lester | 2009-04-30 16:39:33 | Re: Keyword list sanity check |