Re: DTrace probes broken in HEAD on Solaris?

From: Martijn van Oosterhout <kleptog(at)svana(dot)org>
To: Greg Stark <stark(at)enterprisedb(dot)com>
Cc: Robert Lor <Robert(dot)Lor(at)sun(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Zdenek Kotala <Zdenek(dot)Kotala(at)sun(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: DTrace probes broken in HEAD on Solaris?
Date: 2009-03-24 22:53:18
Message-ID: 20090324225317.GC24546@svana.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Mar 24, 2009 at 10:18:08PM +0000, Greg Stark wrote:
> On Tue, Mar 24, 2009 at 10:12 PM, Martijn van Oosterhout
> <kleptog(at)svana(dot)org> wrote:
> > Not really a GCC extension, but you could have the macro check that it
> > can take the address of the arguments, which amounts to almost the same
> > thing. It only doesn't work on constants.
>
> No, there are all kinds of complex expressions which are lvalues --
> anything ending in a pointer dereference for example, which is
> precisely the most likely kind of expression to introduce seg fault if
> something is unexpectedly null

Sorry, I meant to say that the compiler could determine the address at
compile time, something like:

__builtin_constant_p( !&(__x)) )

Have a nice day,
--
Martijn van Oosterhout <kleptog(at)svana(dot)org> http://svana.org/kleptog/
> Please line up in a tree and maintain the heap invariant while
> boarding. Thank you for flying nlogn airlines.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Greg Stark 2009-03-24 23:09:51 Re: DTrace probes broken in HEAD on Solaris?
Previous Message David E. Wheeler 2009-03-24 22:38:18 Re: hstore patch, part 2