| From: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
|---|---|
| To: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: parallel restore fixes |
| Date: | 2009-03-09 23:22:54 |
| Message-ID: | 20090309232254.GI12932@alvh.no-ip.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Andrew Dunstan wrote:
>
> The attached patch fixes two issues with parallel restore:
>
> * the static buffer problem in dumputils.c::fmtId() on Windows
> (solution: use thread-local storage)
> * ReopenPtr() is called too often
Hmm, if pg_restore is the only program that's threaded, why are you
calling init_dump_utils on pg_dump and pg_dumpall? It makes me a bit
nervous because there are some other programs that are linking
dumputils.c (psql and some in src/bin/scripts/) and even calling fmtId.
Also I think the fmtId comment needs to be updated.
--
Alvaro Herrera http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2009-03-09 23:42:59 | Re: parallel restore fixes |
| Previous Message | Hannu Krosing | 2009-03-09 23:09:15 | Re: Updates of SE-PostgreSQL 8.4devel patches (r1704) |