Re: Re: [COMMITTERS] pgsql: Update autovacuum to use reloptions instead of a system catalog,

From: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: ITAGAKI Takahiro <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Re: [COMMITTERS] pgsql: Update autovacuum to use reloptions instead of a system catalog,
Date: 2009-02-11 20:23:49
Message-ID: 20090211202349.GV8924@alvh.no-ip.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Tom Lane wrote:
> Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
> > Tom Lane wrote:
> >> I tend to think this isn't a very good idea. It's difficult for
> >> applications to know whether a toast table will be created or not.
> >> They should be able to just set the toast options and not worry.
>
> > The problem is where do we store the options?
>
> We don't. If there's no toast table, we don't need them after all.

Well, that's the position that the current code is taking.

However, Takahiro-san and Euler's position is that if you do this:

create table foo (f1 int) with (toast.fillfactor = 70);
alter table foo add column f2 text;

Then the toast table should have the fillfactor setting. Right now they
are lost.

If we agree that the options are OK to be lost, then there's nothing we
need to do (and that's my opinion). If we don't, then we need some
weird hack to make it work somehow. Personally I think that it needs a
lot more work than it warrants.

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2009-02-11 20:40:33 Re: Re: [COMMITTERS] pgsql: Update autovacuum to use reloptions instead of a system catalog,
Previous Message Tom Lane 2009-02-11 20:17:36 Re: Re: [COMMITTERS] pgsql: Update autovacuum to use reloptions instead of a system catalog,

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2009-02-11 20:40:33 Re: Re: [COMMITTERS] pgsql: Update autovacuum to use reloptions instead of a system catalog,
Previous Message Tom Lane 2009-02-11 20:17:36 Re: Re: [COMMITTERS] pgsql: Update autovacuum to use reloptions instead of a system catalog,