| From: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
|---|---|
| To: | ITAGAKI Takahiro <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: [COMMITTERS] pgsql: Update autovacuum to use reloptions instead of a system catalog, |
| Date: | 2009-02-10 18:46:18 |
| Message-ID: | 20090210184618.GJ3708@alvh.no-ip.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
ITAGAKI Takahiro wrote:
> 2. psql's \d+ doesn't show toast storage parameters.
>
> Neither \d+ for base tables nor toast relations show toast.* parameters
> though there are some values in pg_class.reloptions.
> I think we should show toast.* parameters in \d+ for base tables
> because it has consistency; we set them at ALTER TABLE for base tables.
This patch seems to fix this problem.
Note that it introduces a LEFT JOIN on pg_class to itself that's always
present, even for server versions that do not support reloptions. I'm
not sure that this is a problem; I can't measure any difference on \d
with and without the patch on a test database with 1000 tables.
| Attachment | Content-Type | Size |
|---|---|---|
| psql-toast-relopts.patch | text/x-diff | 2.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2009-02-10 19:29:39 | pgsql: Support for KOI8U encoding |
| Previous Message | User Bmomjian | 2009-02-10 17:45:08 | pg-migrator - src: Add ability specify super-user. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Sam Mason | 2009-02-10 19:41:11 | Re: Good Delimiter for copy command |
| Previous Message | Simon Riggs | 2009-02-10 18:14:29 | Re: HotStandby-Patch and WAL_DEBUG |