Re: Re: Meridiem markers (was: [BUGS] Incorrect "invalid AM/PM string" error from to_timestamp)

Brendan Jurd wrote:
> On Tue, Jan 27, 2009 at 3:25 PM, Brendan Jurd <direvus(at)gmail(dot)com> wrote:
> > On Tue, Jan 27, 2009 at 3:05 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> >>
> >> strncpy is generally deprecated; any remaining uses you find of it
> >> are probably only there for lack of round tuits. Use strlcpy in new
> >> code, unless there's a pretty strong argument that strncpy is actually
> >> clearer for a given usage.
> >>
> >
> > Thanks for clearing that up Tom. I will update the patch to use
> > strlcpy shortly.
> >
>
> Okay, I've attached a new version of the patch with strlcpy used in
> from_char_set_int_len() and from_char_seq_search(). I've also
> included an incremental patch which shows the differences between
> version 0 and version 1.

I consider this a bug fix so I have applied it to CVS HEAD, even though
the patch arrived after the commit fest started. Thanks.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +