Re: libpq WSACleanup is not needed

Magnus Hagander wrote:
> Bruce Momjian wrote:
> > Andrew Chernow wrote:
> >> Bruce Momjian wrote:
> >>> We could have gone with a more elegant init/uninit solution but there is
> >>> a history of slow upstream adoption of libpq API changes.
> >>>
> >>>
> >> If that's the case, adding a connectdb option seems like a good
> >> alternative. Orignally suggested here:
> >>
> >> http://archives.postgresql.org/pgsql-hackers/2009-01/msg01358.php
> >
> > Right, well the big question is how many people are going to use the
> > connection option vs. doing it for everyone automatically.
> >
> > One possible approach might be to do it automatically, and allow a
> > connection option to disable the WSACleanup() call.
>
> I think that was the suggestion. Have an option that would disable
> *both* the startup and the cleanup call, leaving the responsibility to
> the app.
>
> You can do this for SSL today by calling PQinitSSL().

Right.

> > Actually, right now, if you have two libpq connections, and close one,
> > does WSACleanup() get called, and does it affect the existing
> > connection?
>
> WSACleanup() gets called, but it has an internal reference count so it
> does not have any effect on existing connections.

Ah, OK, so it does its own cleanup on last close, great. I agree a
connection option for this would be good.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +