pgsql: Fix a pg_dump output ordering problem introduced in 8.3 by the

From: tgl(at)postgresql(dot)org (Tom Lane)
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Fix a pg_dump output ordering problem introduced in 8.3 by the
Date: 2009-01-18 20:44:53
Message-ID: 20090118204453.25E42754878@cvs.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Log Message:
-----------
Fix a pg_dump output ordering problem introduced in 8.3 by the addition of
array types for composite types. Although pg_dump understood it wasn't
supposed to dump these array types as separate objects, it must include
them in the dependency ordering analysis, and it was improperly assigning them
the same relatively-high sort priority as regular types. This resulted in
effectively moving composite types and tables up to that same high priority,
which broke any ordering requirements that weren't explicitly enforced by
dependencies. In particular user-defined operator classes, which should come
out before tables, failed to do so. Per report from Brendan Jurd.

In passing, also fix an ill-considered decision to give text search objects
the same sort priority as functions and operators --- the sort result looks
a lot nicer if different object types are kept separate. The recent
foreign-data patch had copied that decision, making the sort ordering even
messier :-(

Tags:
----
REL8_3_STABLE

Modified Files:
--------------
pgsql/src/bin/pg_dump:
pg_dump.c (r1.482 -> r1.482.2.1)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/bin/pg_dump/pg_dump.c?r1=1.482&r2=1.482.2.1)
pg_dump.h (r1.139 -> r1.139.2.1)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/bin/pg_dump/pg_dump.h?r1=1.139&r2=1.139.2.1)
pg_dump_sort.c (r1.20 -> r1.20.2.1)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/bin/pg_dump/pg_dump_sort.c?r1=1.20&r2=1.20.2.1)

Browse pgsql-committers by date

  From Date Subject
Next Message User Jbcooley 2009-01-19 03:20:42 npgsql - Npgsql2: Fixed relationships with a simpler query.
Previous Message Tom Lane 2009-01-18 20:44:45 pgsql: Fix a pg_dump output ordering problem introduced in 8.3 by the