| From: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
|---|---|
| To: | pgsql-hackers(at)postgresql(dot)org |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Gregory Stark <stark(at)enterprisedb(dot)com>, Alan Li <alanwli(at)gmail(dot)com> |
| Subject: | Re: Fixes for compiler warnings |
| Date: | 2009-01-18 09:56:51 |
| Message-ID: | 200901181156.52475.peter_e@gmx.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sunday 18 January 2009 08:28:51 Tom Lane wrote:
> Yeah, the risk this is trying to guard against is variables containing
> "%" unexpectedly. Even if that's not possible, it requires some work
> to verify and it's a bit fragile. I didn't look at the specific cases
> yet but in general I think this is a good policy.
-Wformat-security warns about
printf(var);
but not about
printf(var, a);
I don't understand that; the crash or exploit potential is pretty much the
same in both cases.
-Wformat-nonliteral warns about both cases. We have legitimate code that
requires this, however.
What would be helpful is a way to individually override the warning for the
rare code where you know what you are doing.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Grzegorz Jaskiewicz | 2009-01-18 10:43:46 | Re: Fixes for compiler warnings |
| Previous Message | Peter Eisentraut | 2009-01-18 09:50:09 | Re: Statement-level triggers and inheritance |