Re: FWD: Re: Updated backslash consistency patch

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Peter Eisentraut <peter_e(at)gmx(dot)net>, Greg Sabino Mullane <greg(at)turnstep(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: FWD: Re: Updated backslash consistency patch
Date: 2009-01-15 16:56:38
Message-ID: 200901151656.n0FGucc12881@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Tom Lane wrote:
> Bruce Momjian <bruce(at)momjian(dot)us> writes:
> > Tom Lane wrote:
> >> I think this falls in the category of "be careful what you wish for,
> >> you might get it". It is now blindingly obvious that the folks asking
> >> for that had not actually lived with the behavior for any period of
> >> time.
>
> > I got several emails thanking me for applying the patch, so there is
> > clearly user-demand for 'S'.
>
> Were any of them from people who had actually *used* the patch for more
> than five minutes? I think this is clearly a case of allowing abstract
> consistency considerations to override usability.
>
> The real problem here is that the 'S' suffix for \dt is a bad precedent
> for everything else. If you want consistency then we need to change
> that end of things. I think that the idea of a switch to omit system
> objects, rather than include them, might work.

Please test the attached patch; it reverts to pre-8.4 behavior if any
pattern is present for psql \d commands, including just a simple '*'.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

Attachment Content-Type Size
/pgpatches/psql text/x-diff 10.2 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Rod Taylor 2009-01-15 16:59:35 Re: FWD: Re: Updated backslash consistency patch
Previous Message Heikki Linnakangas 2009-01-15 16:55:42 Re: visibility maps and heap_prune