Re: patch to fix client only builds

Did we address this?

---------------------------------------------------------------------------

Merlin Moncure wrote:
> On Thu, Nov 6, 2008 at 12:45 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> > "Merlin Moncure" <mmoncure(at)gmail(dot)com> writes:
> >> IMO, the client only build should be fixed, so we can:
> >> *) put the makefile hack I proposed in
> >> *) implement the keywords.c change suggested above
> >> *) set up backend/parser symlink from different/additional place.
> >
> > The last of these seems the correct fix. A minimal change would be
> > something like
> >
> > submake-backend:
> > + $(MAKE) -C $(top_builddir)/src/backend $(top_builddir)/src/include/parser/gram.h
> > $(MAKE) -C $(top_builddir)/src/backend/parser keywords.o
> >
>
> Noticed another issue with 'client only' type installs in the
> Makefile. Shouldn't make install on libpq install postgres_ext.h in
> addition to the interface headers?
>
> install: all installdirs install-lib
> $(INSTALL_DATA) $(srcdir)/libpq-fe.h '$(DESTDIR)$(includedir)'
> $(INSTALL_DATA) $(srcdir)/libpq-events.h '$(DESTDIR)$(includedir)'
> $(INSTALL_DATA) $(srcdir)/libpq-int.h '$(DESTDIR)$(includedir_internal)'
> $(INSTALL_DATA) $(srcdir)/pqexpbuffer.h '$(DESTDIR)$(includedir_internal)'
> $(INSTALL_DATA) $(srcdir)/pg_service.conf.sample
> '$(DESTDIR)$(datadir)/pg_service.conf.sample'
>
> merlin
>
> --
> Sent via pgsql-hackers mailing list (pgsql-hackers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgsql-hackers

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +